fix: remove double path resolution in SSH readLines by hobostay · Pull Request #3 · MoonshotAI/kimi-code

hobostay · 2026-05-22T14:50:04Z

Summary

readLines was calling this._resolvePath(path) before passing to this.readText(), which internally calls _resolvePath() again
This made readLines the only method in SSHKaos that double-resolves paths, inconsistent with readBytes, writeBytes, writeText, mkdir, stat, iterdir, and glob

Test plan

Verify existing SSH Kaos tests pass
Confirm readLines with both relative and absolute paths resolves correctly

🤖 Generated with Claude Code

readLines was pre-resolving the path with this._resolvePath() before passing it to this.readText(), which already calls _resolvePath() internally. This made readLines the only method in SSHKaos that double-resolves the path, inconsistent with readBytes, writeBytes, writeText, mkdir, stat, iterdir, and glob. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

liruifengv · 2026-05-23T04:59:11Z

Thank you for your interest in contributing to kimi-code.
However, we currently do not accept bulk AI-generated submissions that have not undergone thorough human review, so we will be closing these PR.

…imeout (Chain 11) Protocol: - FsSearchHit / FsGrepMatch / FsGrepFileHit / FsGitStatusEntry entity schemas - fsSearchRequestSchema / fsSearchResponseSchema (REST.md §3.9 line 575-602) - fsGrepRequestSchema / fsGrepResponseSchema (REST.md §3.9 line 606-643) - 33 new protocol tests (was 286 → now 319) Daemon: - IFsSearchService decorator + FsSearchServiceImpl (services/fs-search.ts) - Cached rg detection via PATH walk (no spawn-which); warn-once via ILogger - rg path uses --json + --no-require-git (so .gitignore respected outside git repos); strips leading "./" from rg-emitted paths - Pure-Node fallback walks gitignore-allowed files + per-line regex - 30s wall-clock timeout via AbortController; rg path SIGKILLs child, Node path breaks the loop; raises FsGrepTimeoutError → 41305 - 500-hit cap for :search → truncated: true (ROADMAP Chain 11 AC #3) - routes/fs.ts adds :search / :grep to the tail-split dispatcher; reuses the W10 fs:<action> routing pattern - start.ts wires IFsSearchService after IFsService (dispose-first ordering) - dispose-order test extends to 17-service chain + new IFsSearchService invariant (disposes before IFsService AND before ISessionService) - 15 new e2e tests + direct service tests for rg-missing fallback and the timeout path (daemon was 176 → now 192) Anti-corruption: 0 SDK imports added. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

@ILogger

VSCode-style static-first / services-last reorder for the daemon's most complex ctor. Before (`ws-gateway.ts:94-100`): constructor( private readonly restGateway: IRestGateway, private readonly registry: IConnectionRegistry, private readonly sessionClients: ISessionClientsService, private readonly eventBus: DaemonEventBus, private readonly logger: ILogger, private readonly options: WSGatewayOptions = {}, ) After: constructor( private readonly eventBus: DaemonEventBus, private readonly options: WSGatewayOptions, @IRestGateway private readonly restGateway: IRestGateway, @IConnectionRegistry private readonly registry: IConnectionRegistry, @ISessionClientsService private readonly sessionClients: ISessionClientsService, @ILogger private readonly logger: ILogger, ) Four service deps now auto-inject; only two static prefix args remain. * `eventBus: DaemonEventBus` stays a concrete-typed static dep because the WsConnection consumer needs the daemon-specific `BufferReplaySource` shape (`getBufferedSince`, `currentSeq`, `addObserver`) which `IEventBus` from `@moonshot-ai/services` does NOT expose. Promoting `DaemonEventBus` to its own identifier is a deliberate followup per ROADMAP P2.3 note + phase-1 reviewer handoff #3. * `options` lost its inline default — TS forbids a required param after an optional one, and we need `options` to follow `eventBus` for static-prefix ordering. start.ts already passes `opts.wsGatewayOptions ?? {}` so the call site is unchanged. * start.ts: the 7-line wire-up `ix.createInstance(WSGateway, a.get(IRestGateway), a.get(IConnectionRegistry), a.get(ISessionClientsService), eventBus, a.get(ILogger), opts.wsGatewayOptions ?? {})` collapses to `ix.createInstance(WSGateway, eventBus, opts.wsGatewayOptions ?? {})`. agent-core/src/di/ untouched (sealed for Phase 2). Daemon build + test green (241 pass; WS handshake / ping / event-broadcast / subscribe / resync e2e all clean). VERDICT: PASS — ws-gateway.ts:103 4 services decorated + start.ts:323 2-arg createInstance; 241/241 daemon tests green.

trustmiao · 2026-06-16T17:45:31Z

计划阶段调查结论（2026-06-17 +08:00）：

需求确认：

fix: remove double path resolution in SSH readLines #3 指出 SSHKaos.readLines 会先调用 this._resolvePath(path)，再把结果传给 this.readText()；而 readText() 内部也会调用 _resolvePath()。
这让 readLines 成为 SSHKaos 文件/目录 API 中唯一重复解析路径的方法，行为与 readBytes、writeBytes、writeText、mkdir、stat、iterdir、glob 不一致。
当前 fix: remove double path resolution in SSH readLines #3 是 closed 状态，已有评论主要是贡献流程反馈；技术需求本身仍可作为一个小范围修复处理。

代码定位：

packages/kaos/src/ssh.ts
- _resolvePath 在约第 465 行：相对路径基于 _cwd join，绝对路径原样返回。
- readText 在约第 706-713 行：读取前会执行 _resolvePath(path)。
- readLines 在约第 716-735 行：当前执行 this.readText(this._resolvePath(path), options)，因此相对路径会被解析两次。
- 其他相关方法只在各自入口解析一次，或直接把解析后的路径传给 SFTP helper。
相关测试：
- packages/kaos/test/e2e/ssh-resolve-path.test.ts 已覆盖 readLines('app.log') 相对路径解析到当前 cwd。
- 现有覆盖没有直接断言 readLines 对绝对路径不会被当前 cwd 重新拼接；这是本问题最需要补的回归测试。

实施计划：

在 packages/kaos/src/ssh.ts 中把 readLines 的读取改为 const text = await this.readText(path, options);，让路径解析只发生在 readText 内部。
保留现有 split 行语义不变：SSHKaos 的 readLines 继续按当前实现移除行终止符，并避免尾随换行产生额外空行。
在现有测试文件中补充最小回归覆盖，优先放到 packages/kaos/test/e2e/ssh-resolve-path.test.ts 的 readText / readBytes / readLines 分组：
- readLines with relative path: 继续确认 cwd 解析到 /var/log/app.log。
- readLines with absolute path: cwd 设为 /var/log，读取 /etc/app.log，断言 SFTP readFile 收到 /etc/app.log，并断言没有收到 /var/log/etc/app.log。
不改公共接口、不新增依赖、不新增 workspace。预计不需要文档更新；如果实现阶段产生用户可见行为变更，再按仓库规则补 changeset。

验证计划：

运行定向测试：pnpm vitest run packages/kaos/test/e2e/ssh-resolve-path.test.ts --config packages/kaos/vitest.config.ts
运行 SSH Kaos 相关测试：pnpm vitest run packages/kaos/test/ssh.test.ts packages/kaos/test/ssh-create.test.ts packages/kaos/test/e2e/ssh-resolve-path.test.ts --config packages/kaos/vitest.config.ts
运行包级类型检查：pnpm --filter @moonshot-ai/kaos run typecheck
最后检查：git diff --check

trustmiao · 2026-06-17T02:54:18Z

Implemented the SSH path-resolution fix for #3.

Changed:

Updated SSH line reads to pass the original path through the text-read path, so path resolution happens once and stays consistent with the other SSH file APIs.
Added regression coverage for absolute line-read paths after changing cwd.
Added a patch changeset for the kaos package and the CLI bundle.

Verification:

corepack pnpm --config.engine-strict=false -C packages/kaos vitest run test/e2e/ssh-resolve-path.test.ts --config vitest.config.ts -> 1 file passed, 20 tests passed.
corepack pnpm --config.engine-strict=false -C packages/kaos vitest run test/ssh.test.ts test/ssh-create.test.ts test/e2e/ssh-resolve-path.test.ts --config vitest.config.ts -> 3 files passed, 82 tests passed, 16 skipped.
corepack pnpm --config.engine-strict=false --filter @moonshot-ai/kaos run typecheck -> passed.
git diff --check -> passed.

Remaining risk:

The available local Node.js is v24.14.0, while this repository requires >=24.15.0. I had to run pnpm with engine-strict disabled for verification; the focused checks passed under that slightly older Node version.
fix: remove double path resolution in SSH readLines #3 was already closed before this update, so no state change was needed.

trustmiao · 2026-06-17T03:14:44Z

Workmonitor issue-flow plan stage 20260617-111303 issue #3

Plan stage investigation for issue #3, checked on 2026-06-17 11:13 +08:00.

Requirement confirmed:

fix: remove double path resolution in SSH readLines #3 reports that SSHKaos.readLines used to call this._resolvePath(path) before delegating to readText().
readText() already resolves the path internally, so readLines became the only SSHKaos file API that double-resolved paths.
The intended behavior is consistency with readBytes, writeBytes, writeText, mkdir, stat, iterdir, and glob: each public operation should resolve the caller path exactly once at the correct layer.
The issue/PR is currently closed, and existing comments include prior workflow feedback plus a previous implementation note. This plan is based on the current repository state and does not modify code.

Code and impact scope:

packages/kaos/src/ssh.ts
- _resolvePath(path) returns absolute paths unchanged and joins relative paths with _cwd.
- readText(path, options) calls sftpReadFile(this._sftp, this._resolvePath(path)).
- readLines(path, options) is the affected method. The correct shape is to delegate with the original path: await this.readText(path, options).
- The line-splitting behavior should remain unchanged: read all text over SFTP, split on CRLF/LF/CR, omit terminators, and avoid an extra empty line for trailing newlines.
packages/kaos/test/e2e/ssh-resolve-path.test.ts
- Existing mocked SFTP tests cover cwd-based resolution for readText/readBytes/readLines.
- The key regression coverage needed for fix: remove double path resolution in SSH readLines #3 is readLines with an absolute path after chdir, asserting SFTP readFile receives the absolute path and not cwd + absolute-looking suffix.
No public interface, package boundary, workspace membership, or provider behavior outside SSHKaos should need to change.

Implementation plan for the implementation stage:

Update SSHKaos.readLines in packages/kaos/src/ssh.ts to call this.readText(path, options) instead of this.readText(this._resolvePath(path), options).
Keep readLines generator output semantics unchanged.
Add or keep a focused regression test in packages/kaos/test/e2e/ssh-resolve-path.test.ts:
- chdir to /var/log;
- create /etc/app.log in the mocked SFTP state;
- call readLines('/etc/app.log');
- assert yielded lines are correct;
- assert readFile was called with /etc/app.log and not /var/log/etc/app.log.
If a changeset is required during implementation, use a patch bump for @moonshot-ai/kaos and the CLI bundle unless later review finds a broader user-visible change.

Verification plan:

Run the focused SSH path-resolution test:
corepack pnpm --config.engine-strict=false -C packages/kaos vitest run test/e2e/ssh-resolve-path.test.ts --config vitest.config.ts
Run related SSH Kaos tests:
corepack pnpm --config.engine-strict=false -C packages/kaos vitest run test/ssh.test.ts test/ssh-create.test.ts test/e2e/ssh-resolve-path.test.ts --config vitest.config.ts
Run kaos typecheck:
corepack pnpm --config.engine-strict=false --filter @moonshot-ai/kaos run typecheck
Run final diff check:
git diff --check

Current local observation:

The working tree already contains local modifications matching the expected fix and regression test, plus unrelated modified files. This plan stage did not edit files.

trustmiao · 2026-06-17T03:17:49Z

Execution stage update for Workmonitor issue-flow plan stage 20260617-111303 issue #3.

Actual changes:

Updated packages/kaos/src/ssh.ts so SSH line reads delegate to readText(path, options) with the caller's original path. Path resolution now happens once inside readText, matching the other SSH file APIs.
Added regression coverage in packages/kaos/test/e2e/ssh-resolve-path.test.ts for readLines('/etc/app.log') after chdir('/var/log'), asserting SFTP reads /etc/app.log and not /var/log/etc/app.log.
Kept the existing readLines split behavior unchanged.
Kept the patch changeset for @moonshot-ai/kaos and @moonshot-ai/kimi-code.

Verification:

corepack pnpm --config.engine-strict=false exec vitest run test/e2e/ssh-resolve-path.test.ts --config vitest.config.ts from packages/kaos: passed, 1 file, 20 tests.
corepack pnpm --config.engine-strict=false exec vitest run test/ssh.test.ts test/ssh-create.test.ts test/e2e/ssh-resolve-path.test.ts --config vitest.config.ts from packages/kaos: passed, 3 files, 82 tests passed, 16 skipped.
corepack pnpm --config.engine-strict=false --filter @moonshot-ai/kaos run typecheck: passed.
git diff --check: passed with only LF/CRLF conversion warnings.

E2E/browser note:

This change affects the SSH Kaos library path-resolution behavior only. It does not affect webpages, API routes, browser flows, or browser interaction, so browser e2e testing is not required for this issue.

Remaining risk:

Local Node.js is v24.14.0 while the repository requires >=24.15.0. I used --config.engine-strict=false for verification; the focused tests and typecheck passed under that slightly older Node version.
The working tree contains unrelated pre-existing WIP files outside this issue scope; I did not modify or revert them.

trustmiao · 2026-06-17T05:32:11Z

Workmonitor issue-flow plan stage 20260617-133039 issue #3

Plan stage investigation checked on 2026-06-17 13:33 +08:00. This stage only investigated and planned; it did not modify code.

Requirement confirmed:

Issue/PR fix: remove double path resolution in SSH readLines #3 is titled "fix: remove double path resolution in SSH readLines" and is currently closed: fix: remove double path resolution in SSH readLines #3
The reported bug is that SSHKaos.readLines called this._resolvePath(path) before delegating to readText().
readText() already resolves the path internally, so readLines double-resolved caller paths and behaved differently from readBytes, writeBytes, writeText, mkdir, stat, iterdir, and glob.
The desired behavior is for readLines to resolve paths exactly once through the same readText path, while preserving existing line-splitting behavior.
Existing comments already include prior workflow feedback plus previous plan/execution notes. This plan is based on the current repository state.

Code and impact scope:

packages/kaos/src/ssh.ts
- _resolvePath(path) is the central helper: absolute paths are returned unchanged, relative paths are joined with the current SSH cwd.
- readText(path, options) calls sftpReadFile(this._sftp, this._resolvePath(path)).
- readLines(path, options) is the affected method. Current working-tree code already shows the intended shape: const text = await this.readText(path, options);
- readLines should keep its existing split semantics: read all text over SFTP, split CRLF/LF/CR terminators, omit terminators, and avoid adding an empty trailing line for a final newline.
packages/kaos/test/e2e/ssh-resolve-path.test.ts
- Existing tests cover readText/readBytes/readLines after chdir with mocked SFTP.
- Current working-tree code already includes the key regression case: after chdir('/var/log'), readLines('/etc/app.log') should read /etc/app.log and should not read /var/log/etc/app.log.
No public API, package boundary, workspace membership, browser UI, API route, or provider behavior outside SSHKaos is expected to change.
The local working tree contains unrelated modified files outside this issue. Those should stay untouched.

Implementation plan for the next stage:

Keep the SSHKaos.readLines implementation in packages/kaos/src/ssh.ts delegating with the original caller path: await this.readText(path, options).
Do not change readLines output semantics or error handling.
Keep/add the focused regression test in packages/kaos/test/e2e/ssh-resolve-path.test.ts for absolute readLines paths after cwd changes:
- chdir to /var/log;
- seed mocked SFTP with /etc/app.log;
- call readLines('/etc/app.log');
- assert yielded lines are correct;
- assert SFTP readFile used /etc/app.log and did not use /var/log/etc/app.log.
Avoid unrelated refactors and leave unrelated working-tree changes alone.
If a changeset is needed during implementation, use the repository gen-changesets skill. This looks like a patch-level bug fix for @moonshot-ai/kaos and any required CLI bundle entry, unless later review finds a broader user-visible semantic change.

Verification plan:

Focused path-resolution test:
corepack pnpm --config.engine-strict=false -C packages/kaos vitest run test/e2e/ssh-resolve-path.test.ts --config vitest.config.ts
Related SSH Kaos tests:
corepack pnpm --config.engine-strict=false -C packages/kaos vitest run test/ssh.test.ts test/ssh-create.test.ts test/e2e/ssh-resolve-path.test.ts --config vitest.config.ts
Package typecheck:
corepack pnpm --config.engine-strict=false --filter @moonshot-ai/kaos run typecheck
Final diff check:
git diff --check

Notes for verification:

The repository requires Node.js >=24.15.0. If the local Node version is still below that, use engine-strict=false only to complete local focused verification and report that limitation explicitly.
Browser or webpage verification is not required for this issue because the affected code is the SSH Kaos filesystem abstraction, not frontend/API behavior.

trustmiao · 2026-06-17T05:34:22Z

Execution stage update for Workmonitor issue-flow plan stage 20260617-133039 issue #3.

Actual changes:

Kept the SSH line-read fix in packages/kaos/src/ssh.ts: readLines now delegates to readText(path, options) with the original caller path, so path resolution happens once inside readText.
Kept readLines line-splitting semantics unchanged.
Kept regression coverage in packages/kaos/test/e2e/ssh-resolve-path.test.ts for readLines('/etc/app.log') after chdir('/var/log'), asserting SFTP reads /etc/app.log and does not read /var/log/etc/app.log.
Confirmed the existing patch changeset .changeset/ssh-read-lines-path.md covers @moonshot-ai/kaos and @moonshot-ai/kimi-code.

Verification:

corepack pnpm -C packages/kaos --config.engine-strict=false exec vitest run test/e2e/ssh-resolve-path.test.ts --config vitest.config.ts passed: 1 file, 20 tests.
corepack pnpm -C packages/kaos --config.engine-strict=false exec vitest run test/ssh.test.ts test/ssh-create.test.ts test/e2e/ssh-resolve-path.test.ts --config vitest.config.ts passed: 3 files, 82 tests passed, 16 skipped.
corepack pnpm --config.engine-strict=false --filter @moonshot-ai/kaos run typecheck passed.
git diff --check passed with LF/CRLF conversion warnings only.

E2E/browser note:

This change affects the SSH Kaos filesystem abstraction only. It does not affect webpages, API routes, user flows, or browser interaction, so e2e/browser testing is not required for this issue.

Remaining risk:

Local Node.js is v24.14.0 while the repository requires >=24.15.0, so verification used --config.engine-strict=false. The focused checks passed under that slightly older Node version.
The working tree contains unrelated pre-existing modified files outside this issue scope; they were left untouched.

trustmiao · 2026-06-17T06:40:49Z

Workmonitor issue-flow plan stage 20260617-143223 issue #3

Plan stage investigation checked on 2026-06-17 14:32 Asia/Shanghai. This stage only investigated and planned; it did not modify code.

Requirement confirmed:

Issue/PR fix: remove double path resolution in SSH readLines #3 is titled "fix: remove double path resolution in SSH readLines" and is currently closed: fix: remove double path resolution in SSH readLines #3
The report says SSHKaos.readLines called this._resolvePath(path) before delegating to readText().
readText() already resolves the path internally, so readLines double-resolved caller paths and differed from readBytes, writeBytes, writeText, mkdir, stat, iterdir, and glob.
Desired behavior: readLines should pass the caller path to readText unchanged, so path resolution happens exactly once, while preserving existing line splitting semantics.
Existing comments include earlier plan/execution notes. This plan is based on the current repository state and current local inspection.

Code and impact scope:

packages/kaos/src/ssh.ts
- _resolvePath(path) returns absolute paths unchanged and joins relative paths with the current SSH cwd.
- readText(path, options) calls sftpReadFile(this._sftp, this._resolvePath(path)).
- readLines(path, options) is the affected method. The expected implementation shape is: const text = await this.readText(path, options);
- readLines should keep the current Python splitlines-style behavior: no line terminators in yielded lines and no extra empty line for a trailing newline.
packages/kaos/test/e2e/ssh-resolve-path.test.ts
- Existing mocked SFTP coverage checks readText/readBytes/readLines with cwd-based path resolution.
- The important regression test is readLines with an absolute path after chdir, asserting SFTP readFile receives /etc/app.log and not /var/log/etc/app.log.
No public API, package boundary, workspace membership, browser UI, web API route, or provider behavior outside SSHKaos is expected to change.
Local working tree observation: there are multiple unrelated modified files. The implementation stage should avoid touching or reverting unrelated WIP.

Implementation plan for the next stage:

In packages/kaos/src/ssh.ts, keep/update SSHKaos.readLines so it calls this.readText(path, options), not this.readText(this._resolvePath(path), options).
Do not alter readLines output semantics, options forwarding, or error behavior.
Keep/add focused regression coverage in packages/kaos/test/e2e/ssh-resolve-path.test.ts:
- chdir to /var/log;
- seed mocked SFTP with /etc/app.log;
- call readLines('/etc/app.log');
- assert yielded lines equal ['line1', 'line2'];
- assert readFile used /etc/app.log and did not use /var/log/etc/app.log.
Avoid unrelated refactors and leave unrelated working-tree changes untouched.
If release metadata is required, use a patch changeset for @moonshot-ai/kaos and any required CLI bundle entry unless later review finds broader user-visible behavior.

Verification plan:

Focused path-resolution test:
corepack pnpm --config.engine-strict=false -C packages/kaos vitest run test/e2e/ssh-resolve-path.test.ts --config vitest.config.ts
Related SSH Kaos tests:
corepack pnpm --config.engine-strict=false -C packages/kaos vitest run test/ssh.test.ts test/ssh-create.test.ts test/e2e/ssh-resolve-path.test.ts --config vitest.config.ts
Package typecheck:
corepack pnpm --config.engine-strict=false --filter @moonshot-ai/kaos run typecheck
Final diff check:
git diff --check

Verification note:

If local Node is still below the repository requirement, use engine-strict=false for focused local verification and report that limitation explicitly.
Browser/e2e UI verification is not required because the affected code is SSHKaos filesystem path resolution, not frontend or API behavior.

trustmiao · 2026-06-17T06:41:24Z

Workmonitor issue-flow plan stage 20260617-143223 issue #3

Plan stage investigation checked on 2026-06-17 14:32 Asia/Shanghai. This stage only investigated and planned; it did not modify code.

Requirement confirmed:

Issue/PR fix: remove double path resolution in SSH readLines #3 is titled "fix: remove double path resolution in SSH readLines" and is currently closed: fix: remove double path resolution in SSH readLines #3
The report says SSHKaos.readLines called this._resolvePath(path) before delegating to readText().
readText() already resolves the path internally, so readLines double-resolved caller paths and differed from readBytes, writeBytes, writeText, mkdir, stat, iterdir, and glob.
Desired behavior: readLines should pass the caller path to readText unchanged, so path resolution happens exactly once, while preserving existing line splitting semantics.
Existing comments include earlier plan/execution notes. This plan is based on the current repository state and current local inspection.

Code and impact scope:

packages/kaos/src/ssh.ts
- _resolvePath(path) returns absolute paths unchanged and joins relative paths with the current SSH cwd.
- readText(path, options) calls sftpReadFile(this._sftp, this._resolvePath(path)).
- readLines(path, options) is the affected method. The expected implementation shape is: const text = await this.readText(path, options);
- readLines should keep the current Python splitlines-style behavior: no line terminators in yielded lines and no extra empty line for a trailing newline.
packages/kaos/test/e2e/ssh-resolve-path.test.ts
- Existing mocked SFTP coverage checks readText/readBytes/readLines with cwd-based path resolution.
- The important regression test is readLines with an absolute path after chdir, asserting SFTP readFile receives /etc/app.log and not /var/log/etc/app.log.
No public API, package boundary, workspace membership, browser UI, web API route, or provider behavior outside SSHKaos is expected to change.
Local working tree observation: there are multiple unrelated modified files. The implementation stage should avoid touching or reverting unrelated WIP.

Implementation plan for the next stage:

In packages/kaos/src/ssh.ts, keep/update SSHKaos.readLines so it calls this.readText(path, options), not this.readText(this._resolvePath(path), options).
Do not alter readLines output semantics, options forwarding, or error behavior.
Keep/add focused regression coverage in packages/kaos/test/e2e/ssh-resolve-path.test.ts:
- chdir to /var/log;
- seed mocked SFTP with /etc/app.log;
- call readLines('/etc/app.log');
- assert yielded lines equal ['line1', 'line2'];
- assert readFile used /etc/app.log and did not use /var/log/etc/app.log.
Avoid unrelated refactors and leave unrelated working-tree changes untouched.
If release metadata is required, use a patch changeset for @moonshot-ai/kaos and any required CLI bundle entry unless later review finds broader user-visible behavior.

Verification plan:

Focused path-resolution test:
corepack pnpm --config.engine-strict=false -C packages/kaos vitest run test/e2e/ssh-resolve-path.test.ts --config vitest.config.ts
Related SSH Kaos tests:
corepack pnpm --config.engine-strict=false -C packages/kaos vitest run test/ssh.test.ts test/ssh-create.test.ts test/e2e/ssh-resolve-path.test.ts --config vitest.config.ts
Package typecheck:
corepack pnpm --config.engine-strict=false --filter @moonshot-ai/kaos run typecheck
Final diff check:
git diff --check

Verification note:

If local Node is still below the repository requirement, use engine-strict=false for focused local verification and report that limitation explicitly.
Browser/e2e UI verification is not required because the affected code is SSHKaos filesystem path resolution, not frontend or API behavior.

trustmiao · 2026-06-17T14:09:24Z

Workmonitor issue-flow plan stage 20260617-214833 issue #3

Plan stage investigation checked on 2026-06-17 22:08 Asia/Shanghai. This stage only investigated and planned; it did not modify code.

Requirement confirmed:

Issue/PR fix: remove double path resolution in SSH readLines #3 is titled "fix: remove double path resolution in SSH readLines" and is currently closed: fix: remove double path resolution in SSH readLines #3
The report says SSHKaos.readLines called this._resolvePath(path) before delegating to readText().
readText() already resolves the path internally, so readLines double-resolved caller paths and was inconsistent with readBytes, writeBytes, writeText, mkdir, stat, iterdir, and glob.
Desired behavior: readLines should pass the caller path to readText unchanged, so path resolution happens exactly once, while preserving existing line-splitting semantics.
Existing comments include prior workflow feedback plus previous plan/execution notes. This plan is based on the current repository state and current local inspection.

Code and impact scope:

packages/kaos/src/ssh.ts
- _resolvePath(path) returns absolute paths unchanged and joins relative paths with the current SSH cwd.
- readText(path, options) calls sftpReadFile(this._sftp, this._resolvePath(path)).
- readLines(path, options) is the affected method. The intended implementation shape is: const text = await this.readText(path, options).
- readLines should keep the current splitlines-style behavior: no line terminators in yielded lines and no extra empty line for a trailing newline.
packages/kaos/test/e2e/ssh-resolve-path.test.ts
- Existing mocked SFTP tests cover readText/readBytes/readLines with cwd-based path resolution.
- The important regression coverage is readLines with an absolute path after chdir, asserting SFTP readFile receives /etc/app.log and not /var/log/etc/app.log.
Local working tree observation: files related to this issue already contain the expected fix and regression test, and there are additional unrelated modified files. The next implementation stage should avoid touching or reverting unrelated WIP.
No public API, workspace membership, browser UI, web API route, or provider behavior outside SSHKaos is expected to change.

Implementation plan for the next stage:

In packages/kaos/src/ssh.ts, keep/update SSHKaos.readLines so it delegates with the original caller path: await this.readText(path, options), not await this.readText(this._resolvePath(path), options).
Do not alter readLines output semantics, options forwarding, or error behavior.
Keep/add focused regression coverage in packages/kaos/test/e2e/ssh-resolve-path.test.ts:
- chdir to /var/log;
- seed mocked SFTP with /etc/app.log;
- call readLines('/etc/app.log');
- assert yielded lines equal ['line1', 'line2'];
- assert SFTP readFile used /etc/app.log and did not use /var/log/etc/app.log.
Avoid unrelated refactors and leave unrelated working-tree changes untouched.
If release metadata is required during implementation, use the gen-changesets skill. This appears to be a patch-level bug fix for @moonshot-ai/kaos and the required CLI bundle entry unless later review finds broader user-visible behavior.

Verification plan:

Focused path-resolution test:
corepack pnpm --config.engine-strict=false -C packages/kaos vitest run test/e2e/ssh-resolve-path.test.ts --config vitest.config.ts
Related SSH Kaos tests:
corepack pnpm --config.engine-strict=false -C packages/kaos vitest run test/ssh.test.ts test/ssh-create.test.ts test/e2e/ssh-resolve-path.test.ts --config vitest.config.ts
Package typecheck:
corepack pnpm --config.engine-strict=false --filter @moonshot-ai/kaos run typecheck
Final diff check:
git diff --check

Verification note:

The repository requires Node.js >=24.15.0. If local Node is still below that, use engine-strict=false only for focused local verification and report that limitation explicitly.
Browser/e2e UI verification is not required because the affected code is SSHKaos filesystem path resolution, not frontend or API behavior.

trustmiao · 2026-06-17T14:11:29Z

Test supplement for Workmonitor issue-flow plan stage 20260617-214833 issue #3.

What was validated:

Ran the existing Kaos SSH e2e test file that covers SSHKaos path resolution, including the regression case for readLines('/etc/app.log') after chdir('/var/log').
Also reran the related SSH Kaos test set, package typecheck, and diff check.

Commands and results:

corepack pnpm --config.engine-strict=false -C packages/kaos exec vitest run test/e2e/ssh-resolve-path.test.ts --config vitest.config.ts -> passed: 1 file, 20 tests.
corepack pnpm --config.engine-strict=false -C packages/kaos exec vitest run test/ssh.test.ts test/ssh-create.test.ts test/e2e/ssh-resolve-path.test.ts --config vitest.config.ts -> passed: 3 files, 82 tests passed, 16 skipped.
corepack pnpm --config.engine-strict=false --filter @moonshot-ai/kaos run typecheck -> passed.
git diff --check -> passed with LF/CRLF conversion warnings only.

Browser/API e2e note:

I did not run browser or API e2e because this issue only changes SSHKaos filesystem path resolution in packages/kaos/src/ssh.ts. It does not touch web UI, API routes, user browser flows, or browser interaction. The corresponding e2e coverage for this change is the existing packages/kaos/test/e2e/ssh-resolve-path.test.ts suite.

Remaining risk:

Local Node.js is v24.14.0, while this repository requires >=24.15.0. I used --config.engine-strict=false for local verification; the focused e2e, related SSH tests, and typecheck all passed under that slightly older Node version.
The working tree still contains unrelated modified files outside the issue fix: remove double path resolution in SSH readLines #3 scope; I left them untouched.

Issue state unchanged; not closing this stage.

trustmiao · 2026-06-17T14:12:14Z

Final summary for Workmonitor issue-flow plan stage 20260617-214833 issue #3.

Coverage confirmed:

Re-read the issue body and all comments. The latest marked plan comment, the execution update, and the test supplement are all present.
The original request was to remove double path resolution in SSHKaos.readLines and keep behavior consistent with the other SSH file APIs.

Final implementation:

packages/kaos/src/ssh.ts: SSHKaos.readLines now delegates with the original caller path via this.readText(path, options). Path resolution happens once inside readText, instead of resolving once in readLines and again in readText.
Existing readLines output semantics are unchanged: line terminators are stripped and a trailing newline does not create an extra empty line.
packages/kaos/test/e2e/ssh-resolve-path.test.ts: added/kept regression coverage for readLines('/etc/app.log') after chdir('/var/log'), asserting SFTP reads /etc/app.log and does not read /var/log/etc/app.log.
.changeset/ssh-read-lines-path.md: patch release metadata is present for the Kaos package and CLI bundle entry.

Verification results:

corepack pnpm --config.engine-strict=false -C packages/kaos exec vitest run test/e2e/ssh-resolve-path.test.ts --config vitest.config.ts -> passed: 1 file, 20 tests.
corepack pnpm --config.engine-strict=false -C packages/kaos exec vitest run test/ssh.test.ts test/ssh-create.test.ts test/e2e/ssh-resolve-path.test.ts --config vitest.config.ts -> passed: 3 files, 82 tests passed, 16 skipped.
corepack pnpm --config.engine-strict=false --filter @moonshot-ai/kaos run typecheck -> passed.
git diff --check -> passed with LF/CRLF conversion warnings only.

E2E status:

Browser/API e2e is not applicable for this issue because the change is limited to the SSHKaos filesystem abstraction in packages/kaos/src/ssh.ts; it does not affect web UI, API routes, user browser flows, or browser interaction.
The relevant e2e coverage is the existing Kaos SSH path-resolution suite, which was run and passed.

Residual risk:

Local Node.js is v24.14.0 while the repository requires >=24.15.0, so local verification used --config.engine-strict=false. The focused e2e, related SSH tests, and typecheck passed under that slightly older Node version.
The working tree contains unrelated modified files outside issue fix: remove double path resolution in SSH readLines #3 scope; they were left untouched.

Status:

The technical requirements for issue fix: remove double path resolution in SSH readLines #3 are satisfied.
The issue/PR is already closed, so no blocker remains for closure.

- kimy wrapper: move hash writes after smoke test (MoonshotAI#1) - kimy wrapper: add public/ to web hash inputs (MoonshotAI#3) - kimy wrapper: widen vis hash to include config files (MoonshotAI#4) - kimy wrapper: move lockfile from /tmp to ~/.kimy/bin (MoonshotAI#5) - kimy wrapper: use explicit package list for native hash (MoonshotAI#7) - 01-bundle.mjs: skip vis-asset build when already done (MoonshotAI#2) - justfile: sync deploy with new wrapper, add deploy-full (MoonshotAI#9,MoonshotAI#10,MoonshotAI#11) - flake.nix: add unpin guidance to nixpkgs comment (MoonshotAI#12)

- add `_serviceBrand` to 17 DI service interfaces and 18 implementations that were missing it (red line #3) - restore bare tool-result slice retention in normalizeToolExchanges (lost in the context-projection rewrite) - make BackgroundTaskPersistence.listTasks skip corrupt task files - add optional dirMode to FileStorageService so background task dirs can be 0700 - fix migrated tests: register IBlobStorage, use the 4-arg BackgroundTaskPersistence construction, add the approval stub and kaos/execute-tool fixtures

#2: Batch appendLoopEvent in executeStepTools — collect all tool.call and tool.result events during for-await, then dispatch once at end. Eliminates N synchronous context array copies per step. #3: Wire tryNativeReadBatch into native-tools.ts — existing Rust nativeBatchRead now callable from the tool layer. Callers fall back to sequential nativeRead when native module unavailable. #1: Async-ify native_edit with spawn_blocking — no longer blocks event loop during parallel tool execution.

…, diff drawer, more rounded corners Five user-reported issues fixed in this batch: MoonshotAI#3 Font-size adjustment now actually works Root cause: App.svelte's :global(body) used the `font:` shorthand with a hardcoded 13px, which won over the global.css `body { font-size: var(--ui-font-size) }` rule (same specificity, later in cascade). The shorthand resets font-size and the slider had no effect. Fix: replace shorthand with individual properties (font-family/size/line-height), keep font-size: var(--ui-font-size). Verified via headless Chromium: default 14px, slider to 20px → 20px, back to 14px → 14px. MoonshotAI#8 Plugin enable/disable ACL error Root cause: PluginPanel called Command.sidecar('kimi', ['plugin', 'disable', id]) which needs shell:allow-execute permission that isn't (and shouldn't be) granted in tauri.conf.json. Fix: added Rust `toggle_plugin(plugin_id, enabled)` command that directly edits ~/.kimi-code/plugins/installed.json (atomic tmp+rename). PluginPanel now invoke()s the new command instead of spawning a sidecar. No ACL needed. MoonshotAI#11 Softer UI — bumped radius tokens --r-sm 6→8, --r-md 8→10, --r-lg 10→14, --r-xl 12→18. Legacy scale bumped in parallel (--radius-xs 6→8, etc.). All components using these tokens get the bump automatically. MoonshotAI#2 Sidebar workspace/session hierarchy Workspace headers are now visually bigger (30px tall, 12.5px bold, with a top border + subtle bg gradient) and the session rows are indented (margin-left: 20px, smaller 11.5px font-weight 400). Workspace count badge becomes a pill instead of plain text. The hierarchy reads cleanly now. MoonshotAI#1 Working-directory diff → second-level right drawer New DiffDrawer.svelte component (540px, slides in from right with spring animation). Clicking a file in the '工作区改动' section of RightPanel opens the drawer; inline expansion is gone. Commit- history diffs stay inline (only the working-directory section was changed per UX request). Esc / ✕ / mask click closes. MoonshotAI#9 Composer compact moved into the main control row '压缩' is now a pill button next to mode/model/thinking instead of a separate FAB below. Per UX request: 'mode / model / thinking / compact all in one row'. Verified: svelte-check 0 errors, cargo check 0 warnings.

liruifengv closed this May 23, 2026

zbl1998-sdjn mentioned this pull request May 29, 2026

Test suite is not portable on Windows (path separators, path.resolve, platform-conditional snapshots, shell) #225

Open

chengluyu added a commit to chengluyu/kimi-code that referenced this pull request Jun 1, 2026

Paused goals inject nothing; blocked keeps a light note (MoonshotAI#3)

de7ad66

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: remove double path resolution in SSH readLines - #3

fix: remove double path resolution in SSH readLines#3
hobostay wants to merge 1 commit into
MoonshotAI:mainfrom
hobostay:fix/ssh-readlines-double-resolve

hobostay commented May 22, 2026

Uh oh!

liruifengv commented May 23, 2026

Uh oh!

trustmiao commented Jun 16, 2026

Uh oh!

trustmiao commented Jun 17, 2026

Uh oh!

trustmiao commented Jun 17, 2026

Uh oh!

trustmiao commented Jun 17, 2026

Uh oh!

trustmiao commented Jun 17, 2026

Uh oh!

trustmiao commented Jun 17, 2026

Uh oh!

trustmiao commented Jun 17, 2026

Uh oh!

trustmiao commented Jun 17, 2026

Uh oh!

trustmiao commented Jun 17, 2026

Uh oh!

trustmiao commented Jun 17, 2026

Uh oh!

trustmiao commented Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

hobostay commented May 22, 2026

Summary

Test plan

Uh oh!

liruifengv commented May 23, 2026

Uh oh!

trustmiao commented Jun 16, 2026

Uh oh!

trustmiao commented Jun 17, 2026

Uh oh!

trustmiao commented Jun 17, 2026

Uh oh!

trustmiao commented Jun 17, 2026

Uh oh!

trustmiao commented Jun 17, 2026

Uh oh!

trustmiao commented Jun 17, 2026

Uh oh!

trustmiao commented Jun 17, 2026

Uh oh!

trustmiao commented Jun 17, 2026

Uh oh!

trustmiao commented Jun 17, 2026

Uh oh!

trustmiao commented Jun 17, 2026

Uh oh!

trustmiao commented Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants